numBytesToRead out of range when recover from large amounts of records
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.6k
- Forks
- 595
- PR merge metrics
- No merged PRs in 30d
Description
FASTERA\cs\src\core\Allocator\MallocFixedPageSize.cs Line 553
int numRecords = (int)numBytesToRead / RecordSize;
When numBytesToRead greater than int.Max() recover will stuck
My fix:
int numRecords = (int)(numBytesToRead / (ulong)RecordSize);
Not sure if this will cause other problems
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open cs/src/core/Allocator/MallocFixedPageSize.cs at line 553 and trace how numBytesToRead is used during recovery. Reproduce recovery with more than int.MaxValue bytes, then verify that the record count remains valid and recovery completes without getting stuck.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100