microsoft / microsoft/Dynamics365Commerce.Solutions

FulfillmentLineCommand setSelectedFulfillmentLines Selects by itemid only

Open
#299 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
80
Forks
38
PR merge metrics
No merged PRs in 30d

Description

API Behavior Issue

Summary

Describe the issue
We using the FulfillmentLineView's-> FulfillmentLineCommand->setSelectedFulfillmentLines method. Setting Fulfillment lines is not matching the exact fulfillment line. It instead selects all fulfillment lines with that ItemId. Our expected behavior is to only select the fulfillment lines passed in.

Version and Error Info
Commerce SDK Component: 9.49.24124.3
Component Version:
Exception/Error Details:

Extension Requirement
Similar to the sample we're trying to implement scanning into this for. We do not aggregate most products, and use a lot of serialized product. Currently we are unable to select just one of many lines so we cannot allow a picker to scan in each picked item.

Reproducing the Issue

Can be reproduced using your own sample for this behavior. Just ensure you have the same item on multiple rows by either using a serialized product or turning off product aggregation in the fuctionality profile.
https://github.com/microsoft/Dynamics365Commerce.InStore/blob/release/9.50/src/StoreCommerceSamples/PosExtensionSamples/Pos/Extend/ViewExtensions/FulfillmentLine/FulfillmentLineCommand.ts

Steps to reproduce the behavior:

  1. Create a customer order
  2. Add a customer
  3. Add the same item on multiple lines. (either serialized or with aggregation off)
  4. Add a full deposit
  5. Set to ship all products
  6. save the order
  7. Open the recall order screen
  8. Select Fulfillment
  9. Click the Scan and Select Product button
  10. Enter in the item
Screenshots

image

Additional context

Are you following a sample that showcases this API? Yes, the fulfillment line command sample.

We'd really appreciate a fix for this as we recently migrated to CPOS and our web fulfillment could really use the ability to scan in products for their web orders. but we require it to be count accurate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the FulfillmentLineCommand.setSelectedFulfillmentLines implementation and the linked FulfillmentLineCommand.ts sample. Reproduce the issue with repeated item lines, serialized products, or aggregation disabled, then trace how the selected fulfillment lines are matched. Done means only the fulfillment lines passed to the method are selected; verify this through the Scan and Select Product flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.