microsoft / microsoft/Dynamics365Commerce.Solutions

[PrePriceOverride stopped working] Issue

Open
#193 3 comments 0 reactions 1 assignee View on GitHub

@madyke is already working on this.

Since Sep 26, 2023.

StoreCommerce
Dominant language
No language data
Stars
80
Forks
38
PR merge metrics
No merged PRs in 30d

Description

When upgrading the CPOS from version 10.0.32 to 10.0.35 the code in the PrePriceOverride stopped working.
For certain items a price override should not be allowed, so a dialog was shown and the code was completed with:

return Promise.resolve({ canceled: true });

The code has not been changed since 2021.
I tried to simplify always execute: return Promise.resolve({ canceled: true });
and nothing else but the code always showed the price change dialog. Show the code was simply:

import * as Triggers from "PosApi/Extend/Triggers/ProductTriggers";
import { ClientEntities } from "PosApi/Entities";
export default class PrePriceOverrideTrigger extends Triggers.PrePriceOverrideTrigger {
    public async execute(options: Triggers.IPrePriceOverrideTriggerOptions): Promise {
        return Promise.resolve({ canceled: true });
    }
}

We have tried below and that's help mitigate the issue Any background story on why this changed in version 10.0.35?
Anything else we need to be aware of?

 return Promise.reject(new ClientEntities.ExtensionError("Not allow price overide"));

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.