microsoft / microsoft/DurableFunctionsMonitor

Vulnerable transitive dependency: axios 0.21.4 via adal-node (CVE-2023-45857)

Open
#318 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs: Triage :mag:
Dominant language
TypeScript
Stars
290
Forks
46
Avg merge
6m
Merged PRs (30d)
1

Description

Title: Vulnerable transitive dependency: axios 0.21.4 via adal-node (CVE-2023-45857)

Body:

The extension (currently latest, v6.8.1) bundles adal-node@0.2.4, which pins
axios: "^0.21.1". This resolves to axios@0.21.4, which is affected by
CVE-2023-45857 (axios leaks the XSRF-TOKEN header to third-party hosts
on cross-origin redirects, fixed in axios 1.6.0).

Path in the installed extension:
node_modules/adal-node/node_modules/axios/package.json → version 0.21.4

Since adal-node is deprecated in favor of MSAL and hasn't been updated
upstream, this can't be resolved by bumping a version range alone.

Could the extension move off adal-node to @azure/msal-node (as Microsoft
recommends for its own deprecated library), or otherwise dedupe/override the
axios version to close this out?

Flagged by our internal security/IT review.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting node_modules/adal-node/node_modules/axios/package.json and the project’s dependency configuration to trace how axios 0.21.4 is installed. Compare the existing adal-node dependency with the proposed @azure/msal-node migration or an override approach. Done means the extension no longer bundles the vulnerable axios version and the CVE is closed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.