microsoft / microsoft/DiskANN

Build_disk_index from Iterator

Open
#671 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
1.9k
Forks
454
Avg merge
3d 22h
Merged PRs (30d)
35

Description

The documentation of `build_disk_index` states:

> This function will construct a DiskANN disk index. Disk indices are ideal for very large datasets that are too large to fit in memory.

However, it only accepts
1) Numpy array: Which cannot by definition fit into memory
2) Path to vector bin file: In order to create this file, I once again need Numpy array: 1)

In other words, this function defeats its own purpose since in order to use it, I need to put all my data that are not supposed to fit into memory... into memory...

I would suggest to make it accept an `Iterator[np.Array]` or correct the documentation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the build_disk_index entry point and its documentation; inspect how the current NumPy-array and vector-bin-path inputs are handled. Done means either iterator input is supported for large datasets or the documentation accurately describes the existing requirements, with relevant tests or documentation checks updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
data, search
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.