microsoft / microsoft/DiskANN

Remove the owned Tokio runtime and synchronous  `DiskIndexSearcher`  API

Open
#1,330 0 comments 0 reactions 1 assignee View on GitHub

@wuw92 is already working on this.

Since Sep 8, 2026.

Dominant language
Rust
Stars
1.9k
Forks
454
Avg merge
3d 22h
Merged PRs (30d)
35

Description

`DiskIndexSearcher`  currently owns a Tokio runtime to provide a synchronous wrapper around its asynchronous search implementation. Internal consumers no longer require the synchronous API, so retaining the runtime adds unnecessary ownership and lifecycle complexity.

Proposed change
- Remove the owned Tokio runtime from  DiskIndexSearcher .
- Remove the synchronous search wrapper.
- Keep the asynchronous search API as the supported interface.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.