[CI] Self hosted benchmark runners should include `rustup`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.9k
- Forks
- 454
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 35
Description
The `setup-disk-benchmark` action currently installs `rustup` via [download](https://github.com/microsoft/DiskANN/blob/2882c7591abc621351622fcafa9918a16a79d4da/.github/actions/setup-disk-benchmark/action.yml#L26-L30). Presumably, because the [self-hosted pool](https://github.com/microsoft/DiskANN/blob/2882c7591abc621351622fcafa9918a16a79d4da/.github/workflows/disk-benchmarks.yml#L56) doesn't include `rustup` by default, unlike Github's normal runners.
This increases our supply chain risk. Instead, it would be better to bundle `rustup` into the runner image and remove the installation step from the workflow.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/actions/setup-disk-benchmark/action.yml and .github/workflows/disk-benchmarks.yml, focusing on the current rustup download and the self-hosted runner configuration. Identify where the runner image is defined, ensure it includes rustup, and verify that the benchmark workflow succeeds without downloading it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, rust
- Domain
- ci-cd, infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100