microsoft / microsoft/DiskANN

QuantCompressor.new_at_stage(): investigate if generation of PQ pivots is needed there

Open
#1,016 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
1.9k
Forks
454
Avg merge
3d 22h
Merged PRs (30d)
35

Description

QuantCompressor.new_at_stage() quantizes a dataset. It expects a file with PQ pivots to exist (a previous step generates it).

However, QuantCompressor.new_at_stage() contains a recovery logic which generates the PQ pivots if the pivots file is missing:

```
if !pivots_exists {
generate_pq_pivots(..);
}

Investigate if this fallback logic is useful.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read QuantCompressor.new_at_stage() and the preceding PQ-pivot generation step, then trace callers that may rely on missing-file recovery. Done means determining whether the fallback is useful and identifying the behavior to remove or change, with the relevant validation updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.