microsoft / microsoft/DirectXShaderCompiler
[SPIR-V] SPV_EXT_descriptor_heap Counter operation on directly-cast heap buffer hits wrong fatal error
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Description
isDescriptorHeapCounterUnsupported (SpirvEmitter.cpp) only recognizes heap-sourced objects via the alias map. A direct-cast form such as ((RWStructuredBuffer<uint>)ResourceDescriptorHeap[i]).IncrementCounter() has no alias-map entry, so the check returns false and the call falls through to an unrelated fatal "array of buffers in a struct" error instead of the intended unsupported-counter diagnostic.
Fix
Replace the alias-map check with spirvOptions.useDescriptorHeap && isHeapSourcedValue(object->IgnoreParenCasts()) so both direct accesses and recorded aliases receive the correct diagnostic.
References
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in SpirvEmitter.cpp at isDescriptorHeapCounterUnsupported and inspect how isHeapSourcedValue handles object->IgnoreParenCasts(). Confirm the direct-cast IncrementCounter case currently reaches the unrelated array-of-buffers fatal error; done means both direct accesses and recorded aliases produce the intended unsupported-counter diagnostic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100