microsoft / microsoft/DirectXShaderCompiler
Remove local D3D12_FEATURE_D3D12_OPTIONS_PREVIEW fallback once GroupSharedLimit ships in a released Windows SDK
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
The HLSLExec GroupSharedLimit tests and their helpers rely on a local fallback definition of D3D12_FEATURE_D3D12_OPTIONS_PREVIEW (and its data struct), which is only available when building against a preview D3D SDK. The tests and helpers are therefore guarded with #if defined(D3D12_PREVIEW_SDK_VERSION) so they compile out on non-preview SDKs.
Once GroupSharedLimit / D3D12_FEATURE_D3D12_OPTIONS_PREVIEW is available in a released Windows SDK, the local fallback and these guards should be removed.
TODOs referencing this issue:
tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpptools/clang/unittests/HLSLExec/HlslExecTestUtils.htools/clang/unittests/HLSLExec/ExecutionTest.cpp
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TODOs in tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp, HlslExecTestUtils.h, and ExecutionTest.cpp, and inspect the local D3D12_FEATURE_D3D12_OPTIONS_PREVIEW fallback and related guards. Build against a released Windows SDK where GroupSharedLimit is available, then run the HLSLExec tests; done means the fallback and preview-only guards are removed while the tests and helpers compile and pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 74/100