microsoft / microsoft/DirectXShaderCompiler
[SPIR-V] Dynamic resources use phi node of resource pointer without specifying capability
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
https://godbolt.org/z/T6qzdPW93
We can see that a phi node is generated between pointers to the resource to access.
Possible solutions would be to add the noted capability as the spir-v validator requires, however this differs to how it is handled in dxil where the index to the global resource should be propagated through control flow instead of the resource.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Godbolt reproducer at https://godbolt.org/z/T6qzdPW93 and inspect the generated SPIR-V around the phi node for resource pointers. Compare this with the described DXIL behavior, then determine whether the completed fix should add the validator-required capability or propagate the global-resource index through control flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100