microsoft / microsoft/DirectXShaderCompiler
Validator should reject i8's
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
We've never intentionally allowed i8, and in fact we disallow 8-bit types at the source level.
The original validator change (#8207) got this bit wrong.
Originally posted by @llvm-beanz in https://github.com/microsoft/DirectXShaderCompiler/pull/8444#discussion_r3226996539
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the original validator change in #8207 and the referenced discussion in PR #8444, then locate the validator handling i8. Check the existing validation coverage and add regression coverage showing that source-level i8 types are rejected.】【。} rf? Wait malformed? Need valid JSON, Armenian accidental. Also sentence says add regression coverage, classify not solve? Research direction can say done. Need valid. Use concise. Ensure no claims existing coverage?
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100