microsoft / microsoft/DirectXShaderCompiler

Review logic of skipping exec tests when hw doesn't support a feature

Open
#8,061 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Should we always call createHWAdapter with SkipUnsupported = false?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating createHWAdapter and every call site that sets SkipUnsupported, then trace how exec tests behave when hardware lacks a feature. The issue does not name files, tests, or an expected outcome, so the completion criteria must be clarified before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.