microsoft / microsoft/DirectXShaderCompiler
[Feature Request] Add preprocessor definition when targeting Metal
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Is your feature request related to a problem? Please describe.
We recently added a -metal flag to DXC to aid with cross-platform development workflows. When that flag is passed we should set a new preprocessor define in InitPreprocessor (something like __metal__) to denote that we're targeting Metal. That will allow for code portability to work around differences in behavior between DX, VK and MTL.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating InitPreprocessor and the existing handling of the -metal flag. Trace how target-specific preprocessor definitions are registered, then identify the relevant compiler tests to update or run. Done means the requested marker is exposed when targeting Metal without changing definitions for other targets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100