microsoft / microsoft/DirectXShaderCompiler

[SPIR-V] Decorations on `vk::BufferPointer` aren't applied with no error or warning

Open
#7,533 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug spirv
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Description

Context: Trying to apply Coherent decoration on PhysicalStorageBuffer address space pointer, because due to lack of Vulkan memory model #7180 we can't use MakeAvailable/MakeVisible on individual load/store and atomics.

Steps to Reproduce

Put a decoration on a vk::BufferPointer variable
https://godbolt.org/z/4qW5zKPzc

Actual Behavior

There's no error or warning, OpDecorate not present in emitted SPIR-V

Environment

  • DXC version
  • Host Operating System <!--- Host operating system and version --->

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Godbolt reproduction linked in the issue and inspect the emitted SPIR-V for the vk::BufferPointer declaration. Trace how the decoration is handled during compilation, then verify that the expected OpDecorate is emitted and that invalid cases produce an error or warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.