microsoft / microsoft/DirectXShaderCompiler

Unable to use -enable-16bit-types in rewriter.

Open
#7,522 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Description
When I'm passing -enable-16bit-types as an argument to RewriteWithOptions, I get the error enable-16bit-types is only allowed for shader model >= 6.2 and HLSL Language >= 2018. But there is no way to specify the target shader model.

Steps to Reproduce
Call dxr.exe with -enable-16bit-types.

Actual Behavior
Allow the user to specify a target shader model, so that -enable-16bit-types is usable.

Environment

  • DXC version: dxcompiler.dll: 1.9 - 1.8.0.4907 (06381f2d7)
  • Host Operating System: Windows 11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how dxr.exe passes options to RewriteWithOptions, focusing on handling for -enable-16bit-types and shader-model validation. Identify the existing option path for selecting a target shader model; done means users can specify that target and use -enable-16bit-types without the reported validation error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.