microsoft / microsoft/DirectXShaderCompiler
[HLK] Add missing tests for `firstbitShi`, `firstbitHi`, `firstbitLo`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Currently we have defined tests for the 16 & 32-bit versions of firstbitShi, firstbitHi, and firstbitLo, however, there is a gap for the 64-bit versions.
This issue tracks the addition of these HLK tests to ensure that behaviour.
For additional context see here: https://github.com/llvm/offload-test-suite/pull/210
AC:
- Add HLK test for 64-bit
Note:
For DirectX-WARP, firstbitShi(s64 -1) = 32 when it should return -1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced ShaderOpArithTable.xml entry around line 2533 and compare the existing 16- and 32-bit tests for firstbitShi, firstbitHi, and firstbitLo. Add the corresponding 64-bit HLK test and verify the DirectX-WARP behavior described in the issue, including the expected result for firstbitShi(s64 -1).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100