microsoft / microsoft/DirectXShaderCompiler
[HLK] Add missing tests for `countbits`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Currently we have defined tests for the 32-bit version of countbits, however, there is a gap for the 16-bit and 64-bit versions.
This issue tracks the addition of these HLK tests to ensure that behaviour.
Note:
For some additional context, it was observed that the 16-bit version was inconsistent across GPU's when tested locally.
For NV we observed that when the input StructuredBuffer was of type int16_t2 or int16_t4, the output was incorrect.
For WARP we observed that when the input StructuredBuffer was of type int16_t3, the output was incorrect.
Please also see here: https://github.com/llvm/offload-test-suite/pull/205.
AC:
- Add HLK test for 16-bit countbits
- Add HLK test for 64-bit countbits
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at tools/clang/unittests/HLSLExec/ShaderOpArithTable.xml around line 2609 and review the existing 32-bit countbits tests. Add HLK coverage for the 16-bit and 64-bit versions, using the issue’s StructuredBuffer observations and the linked offload-test-suite pull request for context. Done means both acceptance-criteria tests are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics, testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100