microsoft / microsoft/DirectXShaderCompiler
Validation: ValidateCallGraph only checks module entry function for non-lib shaders
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
DxilValidation function ValidateCallGraph was never updated for libraries, so it just checks "the" entry function with ValCtx.DxilMod.GetEntryFunction():
and "the" patch constant function, if the shader target is HS:
https://github.com/microsoft/DirectXShaderCompiler/blob/d5951b74d76351c17626bf90daf6684ed8598d3d/lib/DxilValidation/DxilValidation.cpp#L5568-L5569
For library targets, it should check each entry function and each exported function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read lib/DxilValidation/DxilValidation.cpp at ValidateCallGraph, especially the GetEntryFunction and hull-shader patch-constant handling around lines 5562-5569. Trace how library entry and exported functions are represented; done means validation checks each entry and exported function while preserving existing behavior for non-library shaders.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100