microsoft / microsoft/DirectXShaderCompiler
Validation: remove unused gradient and barrier op collecting
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
These gradientOps and barriers sets are unused:
https://github.com/microsoft/DirectXShaderCompiler/blob/d5951b74d76351c17626bf90daf6684ed8598d3d/lib/DxilValidation/DxilValidation.cpp#L2642-L2643
Other than collecting operations into them:
https://github.com/microsoft/DirectXShaderCompiler/blob/d5951b74d76351c17626bf90daf6684ed8598d3d/lib/DxilValidation/DxilValidation.cpp#L2722-L2728
They look like they were meant to be used for something, but there is no code using them, so they should be removed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open lib/DxilValidation/DxilValidation.cpp and inspect the gradientOps and barriers declarations around lines 2642-2643, then the collection logic around lines 2722-2728. Confirm that no other code reads these sets, remove the unused declarations and collecting operations, and run the relevant validation tests or build checks to verify the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100