microsoft / microsoft/DirectXShaderCompiler
Compiling with ClangCL fails
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
ClangCL complains about this function being unused.
https://github.com/microsoft/DirectXShaderCompiler/blob/848b7c42bd8da13693273513412c0a554c7918a1/lib/Support/assert.cpp#L14-L19
Apparently -Wunused-function warning(error) is only enabled for ClangCL so CI never catched it.
https://github.com/microsoft/DirectXShaderCompiler/blob/848b7c42bd8da13693273513412c0a554c7918a1/cmake/modules/HandleLLVMOptions.cmake#L393
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/Support/assert.cpp around lines 14-19 and the -Wunused-function handling in cmake/modules/HandleLLVMOptions.cmake around line 393. Reproduce the ClangCL build failure, then make the smallest change that prevents the unused-function warning from failing compilation and verify the ClangCL build succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100