microsoft / microsoft/DirectXShaderCompiler
[Feature Request] Remove the dependency of libHLSL from libValidation
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Is your feature request related to a problem? Please describe.
Currently libValidation uses AreDxilResourcesDense and DxilSignatureAllocator which cause it dependent on libHLSL.
That will require the validator link libHLSL which is a big library.
Describe the solution you'd like
Reimplement AreDxilResourcesDense in libValidation since it is only used in libValidation.
For DxilSignatureAllocator, create a new lib so libHLSL and libValidation could share it.
Describe alternatives you've considered
Add link of libHLSL.
If only build validator, libHLSL will be built as well.
Additional context
gcc has different linking behavior compared to msvc and clang.
It will report error when libValidator didn't link libHLSL.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementations and uses of AreDxilResourcesDense and DxilSignatureAllocator across libValidation and libHLSL, then inspect how the validator and libraries are linked. Done means libValidation no longer depends on the large libHLSL library, with the shared allocator and resource-density logic building and linking correctly under gcc, MSVC, and Clang.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100