microsoft / microsoft/DirectXShaderCompiler

DxilConfTest::UnaryHalfOpTest#HtanHalf is failing on recent 24H2 build

Open
#6,744 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Description
DxilConfTest::UnaryHalfOpTest#HtanHalf is failing on recent 24H2 build

Steps to Reproduce
it used to pass with 22621 and we notice 24H2 slightly changed the expected values of tanh(1.0), tanh(-1.0) from '0x3a17, 0xba17' to current '0x3a18, 0xba18'.
It looks we also need to enlarge the tolerance for the test, like https://github.com/microsoft/DirectXShaderCompiler/issues/6179

Actual Behavior
element #7, input = 1.00000000(0x3c00), output = 0.76074219(0x3a16), expected = 0.76171875(0x3a18)
Error: Verify: IsTrue(CompareOutputWithExpectedValueHalf(output, ref, type, tolerance)) [File: OSS\dxil\test\hlk\dxilconf.cpp, Function: VerifyOutputWithExpectedValueHalf, Line: 7098]
element #8, input = -1.00000000(0xbc00), output = -0.76074219(0xba16), expected = -0.76171875(0xba18)
Error: Verify: IsTrue(CompareOutputWithExpectedValueHalf(output, ref, type, tolerance)) [File: OSS\dxil\test\hlk\dxilconf.cpp, Function: VerifyOutputWithExpectedValueHalf, Line: 7098]

Environment

  • DXC version dxc_2024_05_24
  • Host Operating System win11 24h2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in OSS\dxil\test\hlk\dxilconf.cpp, focusing on DxilConfTest::UnaryHalfOpTest#HtanHalf and VerifyOutputWithExpectedValueHalf at line 7098. Compare the expected half values and tolerance with the behavior reported on Windows 11 24H2; done means the test accepts the current tanh(1.0) and tanh(-1.0) results while retaining coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.