microsoft / microsoft/DirectXShaderCompiler
en_US is being assumed to be present for string conversion on all systems.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Description
A recent change was made to update string conversion helpers to always use UTF-8. It was noticed on linux platforms that the wrapper code performing the conversions was assuming that the locale en_US.UTF-8 is always present. This may not be the case.
A full revisit of the string conversion approach needs to be done and this assumption addressed.
In addition to this en-US assumption, the usage of LC_ALL for setting locale settings over using just LC_CTYPE needs revisting.
Environment
- Host Operating System Linux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the wrapper code for string conversion helpers and the locale setup used on Linux. Investigate where en_US.UTF-8 is assumed and how LC_ALL is used instead of LC_CTYPE. Done means the conversion approach no longer requires that locale to be installed and locale handling is addressed without regressing Linux behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, operating-systems
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100