microsoft / microsoft/DirectXShaderCompiler
[Feature Request] Improved test coverage for explicit wave size [range] annotations
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Is your feature request related to a problem? Please describe.
While looking at wave size test content, I noticed that the only driver-level tests for the DXIL annotations around wave size don't actually test much. They literally only return the output of WaveGetLaneCount without validating that the wave actually behaves as if it is that size.
Describe the solution you'd like
The tests for the various wave ops should be augmented to run with explicit wave sizes and ranges, and ideally iterate over the device's supported wave sizes. Most devices only support 1, 2, or 3 wave sizes (with an upper bound of 5 possible), and the tests are pretty quick, so it shouldn't be too onerous in terms of execution time.
Describe alternatives you've considered
N/A
Additional context
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing driver-level tests for DXIL wave-size annotations and reviewing how the current WaveGetLaneCount checks are structured. Extend the relevant wave-operation tests to cover explicit wave sizes and ranges, iterating over supported device sizes; done means the tests verify actual wave behavior rather than only returning the lane count.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100