microsoft / microsoft/DirectXShaderCompiler
[Validation] Wave size range tests do not have coverage for when the minimum and maximum are equal
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Is your feature request related to a problem? Please describe.
The wave range size spec details that there should be validation for when the minimum and maximum range values are equal. In such a case, there should be an error that is emitted. Currently, there is no test that provides coverage in this case.
Describe the solution you'd like
We should double check that an implementation for checking whether the min and max range values are equal is present, and add a test that exercises this edge case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the wave range size validation specs and locate the existing tests for minimum and maximum range values. Verify that equal minimum and maximum values emit an error, add coverage for that edge case, and run the relevant validation tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100