microsoft / microsoft/DirectXShaderCompiler
Move Patch constant `inout` parameter check to Sema
Open
Nobody has claimed this yet.
enhancement
tech-debt
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Follow up to https://github.com/microsoft/DirectXShaderCompiler/pull/6363
DXIL has a check to verify a PatchConstant function has no inout parameter.
This should be moved to Sema so both backends can benefit from it.
Right now SPIR-V backend errors, but with a different message.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing DXIL check for PatchConstant functions and the corresponding SPIR-V diagnostic. Move the validation into Sema so both backends reject an inout parameter with the shared check and message; add or update coverage for both backend paths if the existing tests identify them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100