microsoft / microsoft/DirectXShaderCompiler
Several verifier test checks not being run in HLSLFileCheck folder
Open
Nobody has claimed this yet.
tech-debt
test
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
The test at tools/clang/test/HLSLFileCheck/hlsl/types/conversions/attributes_Mod.hlsl has many expected-warning, fxc-pass, fxc-warning and verify-ast comments, but I don't think any are being checked since the RUN line is just for FileCheck.
This is a follow up from #6196
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tools/clang/test/HLSLFileCheck/hlsl/types/conversions/attributes_Mod.hlsl and inspect its RUN line alongside the expected-warning, fxc-pass, fxc-warning, and verify-ast comments. Read follow-up issue #6196 for context. Done means the listed verifier checks are actually run for this test rather than only FileCheck.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100