microsoft / microsoft/DirectXShaderCompiler
lib/DxilPIXPasses/DxilDebugInstrumentation.cpp's addStepEntryForType should do the null check, instead of the caller
Open
@jeffnn is already working on this.
Since Feb 14, 2024.
bug
PIX
tech-debt
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Description
Code issue noted in cherry-pick review:
https://github.com/microsoft/DirectXShaderCompiler/pull/6300
Steps to Reproduce
No repro. Code issue.
Actual Behavior
No behavior change expected.
Environment
Not relevant.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.