microsoft / microsoft/DirectXShaderCompiler

Asserts are used in place of DXASSERT in shader debug passes

Open
#6,307 1 comment 0 reactions 1 assignee View on GitHub

@jeffnn is already working on this.

Since Feb 14, 2024.

bug PIX tech-debt
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Description
See bob80905's comments on PR https://github.com/microsoft/DirectXShaderCompiler/pull/6300
In summary, "assert" was used when "DXASSERT" is preferred. Plus, some of the asserts are just plain "assert(false)" and could be refactored into something more meaningful.

Steps to Reproduce
(Code issue. No repro exists.)

Actual Behavior
"assert" is used!

Environment
None. Code issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.