microsoft / microsoft/DirectXShaderCompiler
[Test] Move clang diagnostic tests to verifiertest.cpp
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Is your feature request related to a problem? Please describe.
GSMainMissingAttributeFail and GSOtherMissingAttributeFail are tests in validationTest.cpp that do not belong in that location.
Describe the solution you'd like
A clear and concise description of what you want to happen.
These tests, and any other tests inside validationTest that only test clang diagnostics should really be moved to VerifierTest.cpp, and should use -verify if the new lit framework is being used. The tests should be converted so that they can be run in the VerifierTest area.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in validationTest.cpp with GSMainMissingAttributeFail and GSOtherMissingAttributeFail, then compare the diagnostics tests in VerifierTest.cpp and the new lit framework. Move the applicable clang-diagnostic tests, convert them to use -verify, and confirm they run in the VerifierTest area.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100