microsoft / microsoft/DirectXShaderCompiler

[Github] Enable "Require conversation resolution before merging" ?

Open
#5,790 3 comments 0 reactions 1 assignee View on GitHub

@pow2clk is already working on this.

Since Sep 27, 2023.

enhancement
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Hello!

auto-merge is enabled in the repo, which is great.
But if you have a single nit to report, but want to give LGTM (so people in other timezones don't have to wait another day just for a nit), the auto-submit seems to kick in directy.
It seems that Github has an option: "Require conversation resolution before merging"

Shall this be enabled on the main branch?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.