microsoft / microsoft/DirectXShaderCompiler

[Feature Request] support hash stability test in lit

Open
#5,595 0 comments 0 reactions 1 assignee View on GitHub

@python3kgae is already working on this.

Since Aug 30, 2023.

enhancement tech-debt test
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Is your feature request related to a problem? Please describe.
Hash stability test only works in taef and it blocks move taef FileCheck test to lit FileCheck test

Describe the solution you'd like
Add a new lit format for hash stability test.

Describe alternatives you've considered
Add extra RUN line for all the test shaders.
Huge change.
Add lit FileCheck folder to the taef hash stability test.
It would be nice to not add more taef tests.

Additional context
We have lit FileCheck test and taef FileCheck test now.
Moving taef FileCheck test to lit FileCheck test folder will reduce the coverage of taef hash stability test.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.