microsoft / microsoft/DirectXShaderCompiler
[Validation] Add validation for Annotate*Handle intrinsics
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Describe the solution you'd like
DxilValidation.cpp should have proper validation for Annotate*Handle intrinsics. The validation should go deeper than just validating that the handle arguments are valid.
Describe alternatives you've considered
All the possible valid sources of a handle should be tested for, like testing to see the handle originated from a create*Handle call, or came from an external constant, etc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in DxilValidation.cpp by locating validation for the AnnotateHandle intrinsics and reviewing how handle arguments are currently checked. Cover the valid handle sources named in the issue, including createHandle calls and external constants, and verify that invalid origins are rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100