microsoft / microsoft/DirectXShaderCompiler

Rewriter: entrypoint function's param referenced types are removed when param is not used.

Open
#5,290 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug rewriter
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Hello,
the following shader rewrite with dxr.exe -remove-unused-functions -remove-unused-globals -E ps_main

struct VS_OUTPUT
{
    float4 position : SV_Position;
    float4 uv : TEXCOORD0;
    float4 color : VC;
};   

float4 ps_main(VS_OUTPUT input) : SV_Target0 
{
    return float4(0, 0, 0, 0);
}

output will be

float4 ps_main(VS_OUTPUT input) : SV_Target0 
{
    return float4(0, 0, 0, 0);
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the HLSL reproducer with dxr.exe using -remove-unused-functions, -remove-unused-globals, and -E ps_main, then trace the rewriter's handling of the ps_main entrypoint parameter and its referenced VS_OUTPUT type. Done means the rewritten output preserves the required parameter type definition even when the parameter is not used.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.