microsoft / microsoft/DirectXShaderCompiler
IDxcIndex::ParseTranslationUnit has no mechanism to honor an IDxcIncludeHandler
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
As far as I can tell, the IDxcIncludeHandler passed as an optional interface to IDxcCompiler::Compile results in a custom DXC-specific filesystem proxy. However, when invoking ParseTranslationUnit on an IDxcIndex, the filesystem used is an instance of llvm::sys::fs::MSFileSystem (ref. dxcisenseimpl.cpp). Would it make sense to leverage the same filesystem mechanism for the Intellisense interface also?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading dxcisenseimpl.cpp and tracing how IDxcIndex::ParseTranslationUnit selects its filesystem. Compare that path with the IDxcCompiler::Compile handling of IDxcIncludeHandler and its DXC-specific filesystem proxy. Done means the desired include-handler behavior for the Intellisense interface is defined and implemented, with relevant validation identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100