microsoft / microsoft/DirectXShaderCompiler
Add D3D_SVC_BIT_FIELD to D3D_SHADER_VARIABLE_CLASS
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
This is following up for
https://github.com/microsoft/DirectXShaderCompiler/pull/5142
D3D_SVC_BIT_FIELD is added as macro define in https://github.com/microsoft/DirectXShaderCompiler/pull/5142
It should be declared in D3D_SHADER_VARIABLE_CLASS
Note: issue here is that DXC is essentially casting an integer value to D3D_SHADER_VARIABLE_CLASS becuase the D3D headers haven't been updated with the new value. So this is tracking work to modify the D3D headers appropriately.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the D3D_SHADER_VARIABLE_CLASS declaration and the D3D_SVC_BIT_FIELD macro, then read the linked pull request 5142 for the existing change. Confirm where the D3D headers define this enum and update the declaration so the new value is represented directly rather than through an integer cast; verify the relevant compiler checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100