microsoft / microsoft/DirectXShaderCompiler
[feature request] Copying "this" fails
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.7k
- Forks
- 900
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 44
Description
Doing this.blah works and appears to be in the unit tests. Except that is useless in practice since omitting the "this." gives equivalent code. What is useful is returning or copying "this". Doing so errors in DXC but does not in FXC with the following:
error: cannot compile this aggregate expression yet
https://shader-playground.timjones.io/a60a95d27b98a13ad73f3a8ddeda7a02
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the shader-playground example linked in the issue and compare DXC's behavior with FXC. Then locate the existing unit tests for this member access and determine where aggregate expressions are rejected; done means returning or copying this compiles in DXC and has coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100