microsoft / microsoft/DirectXShaderCompiler

DXIL validation should run ComputeViewIdState pass

Open
#4,256 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

The serialized view ID state in the DXIL module is not validated against the rest of the contents of the module. Tools that produce DXIL (like the Mesa DXIL writer) can just not emit a view ID metadata node, even though they're using view ID, and validation will succeed. This also includes the input -> output dependency mapping data, which can just be omitted entirely without affecting validation.

If drivers need this data, it should be validated as part of the validator.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DXIL validator and the ComputeViewIdState pass mentioned in the issue. Trace how serialized view ID state and input-to-output dependency mapping are handled, then add validation coverage showing that missing or inconsistent metadata is rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.