microsoft / microsoft/DirectXShaderCompiler

Missing implementation for HLOpcodeGroup::NotHL in TranslateCBAddressUserLegacy

Open
#3,251 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug crash
Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Repro:

Compile the following, (I used as_6_5, /Zi -enable-16bit-types /Qembed_debug )

struct LinearSHSampleData
{
       float4 linearTerms[3];
       float4 hdrColorAO;
       float4 visibilitySH;
} g_lhSampleData;

struct smallPayload
{
    LinearSHSampleData lhSampleData;
};


[numthreads(1, 1, 1)]
void main()
{
    smallPayload p;
    p.lhSampleData = g_lhSampleData;
    DispatchMesh(1, 1, 1, p);
}

I hit this line in TranslateCBAddressUserLegacy, HLOperationLower.cpp:6207:

  DXASSERT(0, "not implemented yet");

The call instruction at issue is:
CI->dump()
call void @llvm.memcpy.p0i8.p0i8.i64(i8* %4, i8* %5, i64 80, i32 1, i1 false), !dbg !44

This assert is firing because the called function has group == HLOpcodeGroup::NotHL

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in HLOperationLower.cpp at TranslateCBAddressUserLegacy, around line 6207, and inspect how the llvm.memcpy call is classified before the assertion. Use the provided DispatchMesh repro and its dumped call instruction as the regression case. Done means the repro no longer triggers the not-implemented assertion and the memcpy call is handled correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.