microsoft / microsoft/DirectXShaderCompiler

Structs passed to subroutines (can) cause the numbering pass to get confused about offsets of members

Open
#2,923 1 comment 0 reactions 1 assignee View on GitHub

@jeffnn is already working on this.

Since May 27, 2020.

Dominant language
C++
Stars
3.7k
Forks
900
Avg merge
2d 11h
Merged PRs (30d)
44

Description

Repro: edit the PixStructAnnotation_SequentialFloatN case in DXCompiler's pixtest.cpp to pass the payload struct to a subroutine, and have the subroutine call DispatchMesh, then run the unit test.

Not clear yet what set of structs are affected. Certainly there are structs in the wild that don't show this problem- could be something to do with the fact that those shaders were compiled with older dxc, or something to do with the structs themselvs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.