microsoft / microsoft/DirectX-Graphics-Samples
D3D12HDR::EnsureSwapChainColorSpace gamma documentation
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- PR merge metrics
- No merged PRs in 30d
Description
Comment mentions Gamma 2.2 in FP16:
// DirectX supports two combinations of swapchain pixel formats and colorspaces for HDR content.
// Option 1: FP16 + DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P709
// Option 2: R10G10B10A2 + DXGI_COLOR_SPACE_RGB_FULL_G2084_NONE_P2020
Code sets Gamma 1.0 in FP16:
case _16:
colorSpace = DXGI_COLOR_SPACE_RGB_FULL_G10_NONE_P709;
m_rootConstants[DisplayCurve] = None;
break;
Is it correct?
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read Samples/Desktop/D3D12HDR/src/D3D12HDR.cpp around EnsureSwapChainColorSpace at line 925. Compare the FP16 comment mentioning Gamma 2.2 with the _16 case setting DXGI_COLOR_SPACE_RGB_FULL_G10_NONE_P709. Done means establishing which value is correct and aligning the comment or code with that conclusion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics, documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100