microsoft / microsoft/DirectX-Graphics-Samples
There is no need to call UnbindAllValid(); function in dynamicdescriptorheap.cpp
@stanard is already working on this.
Since Mar 6, 2024.
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- PR merge metrics
- No merged PRs in 30d
Description
In the DynamicDescriptorHeap.cpp file, the function CopyAndBindStagedTables is used for committing the descriptors table. However, the mini-engine calls the unbindAllValid function before committing the descriptors table, which is meaningless.
The UnbindAllValid function is used to update the m_StaleRootParamsBitMap according to the assignment of the descriptor tables. You don't need to call this function in the statement of committing the descriptors table. When I delete the code about the UnbindAllValid, the engine is still running well.
For better readability, I think we should delete the code about the UnbindAllValid.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.