microsoft / microsoft/DirectX-Graphics-Samples
HDR Sample treating Min/MaxMasteringLuminance as the same range?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- PR merge metrics
- No merged PRs in 30d
Description
Hello!
I was looking at the HDR sample here: https://github.com/microsoft/DirectX-Graphics-Samples/blob/master/Samples/Desktop/D3D12HDR/src/D3D12HDR.cpp#L994
And it seems to treat MaxMasteringLuminance and MinMasteringLuminance as the same range/scale.
Whereas the docs say:
MaxMasteringLuminance
The maximum number of nits of the display used to master the content. Values are in whole nits.
MinMasteringLuminance
The minimum number of nits of the display used to master the content. Values are 1/10000th of a nit (0.0001 nit).
Is the sample wrong, are the docs wrong, or am I just misunderstanding?
Thanks for your time!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect Samples/Desktop/D3D12HDR/src/D3D12HDR.cpp around line 994 and compare the sample's MinMasteringLuminance and MaxMasteringLuminance handling with the cited documentation. Determine whether the sample or documentation uses the incorrect scale, then update the affected source or documentation and verify the HDR sample behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100