microsoft / microsoft/DirectX-Graphics-Samples
TemporalAA still called when disabled
Open
Beginner friendly
Nobody has claimed this yet.
bug
samples
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
It seems TemporalAA is not off when EnableTAA is false.
ApplyTemporalAA and SharpenImage still called.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in MiniEngine/Core/TemporalEffects.cpp at the referenced lines around 163-166, then trace the calls to ApplyTemporalAA and SharpenImage. Verify that both calls are skipped when EnableTAA is false, while the existing behavior remains when it is true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 60/100