microsoft / microsoft/DirectX-Graphics-Samples
Some D3D12RayTracing samples using incorrect CommandList Interface
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- PR merge metrics
- No merged PRs in 30d
Description
I have a 2080TI and a TitanV. I ensured that the 2080TI was being selected. What I found was that in several of the D3D12 Raytracing samples, ID3D12GraphicsCommandList5 is being used, which according to this:
https://docs.microsoft.com/en-us/windows/win32/api/d3d12/nn-d3d12-id3d12graphicscommandlist5
is for Variable Rate Shading.
Instead what is needed is ID3D12GraphicsCommandList4
https://docs.microsoft.com/fr-fr/windows/win32/api/d3d12/nn-d3d12-id3d12graphicscommandlist4
Which is for ray tracing.
I could not get D3D12RaytracingProceduralGeometry, nor D3D12RaytracingSimpleLighting working without making this change
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the D3D12RaytracingProceduralGeometry and D3D12RaytracingSimpleLighting samples, focusing on their command-list interface usage. Compare the interfaces against the linked D3D12 documentation and verify that the samples use ID3D12GraphicsCommandList4 for ray tracing; done means both samples work on the reported hardware.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100