microsoft / microsoft/DirectX-Graphics-Samples

MiniEngine: maybe memory leak in EngineTuning::AddToVariableGraph

Open
#541 0 comments 0 reactions 1 assignee View on GitHub

@stanard is already working on this.

Since Sep 20, 2021.

bug miniengine
Dominant language
C++
Stars
6.8k
Forks
2.2k
No merged PRs in 30d

Description

file: EngineTuning.cpp
func: AddToVariableGraph
line: 669

in the file: GraphicsCore.cpp line:214
init some EngineVar like 'NumVar BicubicUpsampleWeight("Graphics/Display/Bicubic Filter Weight", -0.75f, -1.0f, -0.25f, 0.25f);'
if the first param has char '/', when EngineTuning::Initialize, will new VariableGroup.
but I can't see any free memory in the code.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.