microsoft / microsoft/DevSkim

[False Positive] DS106863 - The DES cipher was found, which is widely considered to be broken.

Open
#645 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

false positive
Dominant language
C#
Stars
1k
Forks
131
Avg merge
1m
Merged PRs (30d)
1

Description

Rule ID

DS106863 The DES cipher was found, which is widely considered to be broken.

What the rule matched

var location = "some text DES";
//...
if (location.EndsWith("DES")) //<-- The DES cipher was found, which is widely considered to be broken.
{
  location = location[..^4];
}

Why should this not be matched?

Is is just a string in a string comparision.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating rule DS106863 in DevSkim and reproduce the reported C# snippet containing the string comparison. The fix is done when this non-cryptographic use of "DES" is not reported as a broken cipher, while the rule's intended detection remains covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.