microsoft / microsoft/Detours

DetourBinaryWrite doesn't handle .bss segments correctly

Open
#63 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help-wanted
Dominant language
C++
Stars
6.4k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

This type of segment has a data size in memory (SizeOfRawData > 0) but stores no data in the object file itself.
The problem occurs when Image::Write tries to write the segment to the file. A check needs to made for PointerToRawData == NULL

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Image::Write and trace how DetourBinaryWrite handles segments with SizeOfRawData greater than zero. Check the PointerToRawData == NULL case so a .bss segment with no object-file data is not written incorrectly. Done means .bss segments are written successfully while ordinary segments retain their existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.