`detour_skip_jmp` for x64 doesn't support `rex.w` prefix
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 6.4k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I found that DetourCodeFromPointer doesn't work propely for OutputDebugStringA on x64 platform because detour_skip_jmp doesn't handle rex.w (0x48) prefix before jmp [+imm32] (0xFF, 0x25, 0xXX, 0xXX, 0xXX, 0xXX). Could you please fix it?
https://github.com/microsoft/Detours/blob/734ac64899c44933151c1335f6ef54a590219221/src/detours.cpp#L380
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/detours.cpp around line 380, focusing on detour_skip_jmp as called by DetourCodeFromPointer. Reproduce the OutputDebugStringA case on x64 and verify that the reported rex.w-prefixed indirect jump is handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100